fix: render fields on document load

[dguyen]

Description

Currently if you try to load the document edit page when fields need to be rendered, you will not be able to see the fields until you proceed to the next step.

This is because the fields require the document PDF to be loaded prior to rendering them.

This PR resolves that issue by only rendering the fields after the PDF is loaded.

Changes Made

• Add a state to track whether the PDF is loaded
• Render the fields only after the PDF is loaded

Testing Performed

Tested document flow manually and the fields are rendered correctly on load.

Checklist

• I have tested these changes locally and they work as expected.
• I have updated the documentation to reflect these changes, if applicable.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stg-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 6:06am
stg-marketing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 27, 2024 6:06am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
prd-app	⬜️ Ignored (Inspect)			Mar 27, 2024 6:06am
prd-marketing	⬜️ Ignored (Inspect)			Mar 27, 2024 6:06am

[Mythie]

I thought we handled this with an element visible component which renders the children once it can find a PDF page? 🤔

[dguyen]

It's something to do with the window.document not being available immediately. So an error is thrown in the createPortal when trying to access document.body & also in the coordinate calculation.

Initially I fixed it by waiting for the window to load, but then the fields were rendered with the incorrect height and there were some weird bugs, so I just defaulted to wait for the document PDF to be loaded instead.

We can try to resolve properly if you want, I just think this is a fast solution

[Mythie]

Fast is fine for now