fix: document audit log field security migration #1081
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When document audit logs were first introduced, we by default set the
fieldSecurity
toNONE
Now that document auth has been added, this is causing issues since we do not use
NONE
to define field that has no migrations required, but rather have thefieldSecurity
field itself be undefined.To keeps things consistent, this migration replaces
NONE
with undefined.There are a few ways to approach this:
parseDocumentAuditLogData
NONE
instead of undefinedIf anyone thinks there's a better way to do this, please drop a comment 🙇