fix: return updated doc

[catalinpit]

Description

Fetch the updated version of the document after sealing it and return it. Previously, the document.documentData.data wasn't up to date. Now it is.

Related Issue

Fixes #1088.

Testing Performed

• Added console.logs in the code to make sure it returns the proper data
• Set up a webhook and tested that the webhook receives the updated data

Checklist

• I have tested these changes locally and they work as expected.
• I have added/updated tests that prove the effectiveness of these changes.
• I have updated the documentation to reflect these changes, if applicable.
• I have followed the project's coding style guidelines.
• I have addressed the code review feedback from the previous submission, if applicable.

[coderabbitai]

Walkthrough

The update to the sealDocument function marks a significant improvement in the way document data is handled. By fetching the latest document from the database before triggering a webhook, it ensures that the most current and accurate document data is used. This change directly addresses the issue where outdated document data was passed to the trigger function, enhancing the reliability and accuracy of the system's operations.

Changes

File(s)	Summary
.../server-only/document/seal-document.ts	Updated to fetch the latest document data from the database before triggering a webhook.

Assessment against linked issues

Objective	Addressed	Explanation
[#1088]: Old data passed to trigger function	✅

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stg-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2024 0:17am
stg-marketing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 8, 2024 0:17am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
prd-app	⬜️ Ignored (Inspect)			Apr 8, 2024 0:17am
prd-marketing	⬜️ Ignored (Inspect)			Apr 8, 2024 0:17am

[github-actions]

🚨 @catalinpit has 5 pull requests awaiting review. Please consider reviewing them when possible. 🚨

[coderabbitai]

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between fc70f78 and 00af552.

Files selected for processing (1)

• packages/lib/server-only/document/seal-document.ts (1 hunks)

Additional comments not posted (3)

packages/lib/server-only/document/seal-document.ts (3)

156-164: Fetching the updated document after sealing ensures that the most current data is used. This is a crucial fix for the issue described.

---

165-168: Triggering the webhook with the updated document data is a good practice. It ensures that downstream systems receive the most accurate and current information.

---

153-171: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-168]

Ensure robust error handling for database operations, PDF processing, and file operations to enhance system reliability.