Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: status widget rerendering #1097

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: status widget rerendering #1097

merged 2 commits into from
Apr 10, 2024

Conversation

thibaultleouay
Copy link
Contributor


name: Pull Request
about: Submit changes to the project for review and inclusion

Description

Should fix the rerendering of the status widget

Related Issue

Changes Made

  • Change 1
  • Change 2
  • ...

Testing Performed

  • Tested feature X in scenario Y.
  • Ran unit tests for component Z.
  • Tested on browsers A, B, and C.
  • ...

Checklist

  • I have tested these changes locally and they work as expected.
  • I have added/updated tests that prove the effectiveness of these changes.
  • I have updated the documentation to reflect these changes, if applicable.
  • I have followed the project's coding style guidelines.
  • I have addressed the code review feedback from the previous submission, if applicable.

Additional Notes

Copy link

vercel bot commented Apr 10, 2024

@thibaultleouay is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Walkthrough

The recent updates to the marketing app components primarily focus on enhancing the StatusWidget by introducing a new slug prop and optimizing its rendering through memoization. This modification ensures that the widget is more efficient and tailored to specific statuses, encapsulated within a Suspense component for better loading management.

Changes

File Path Change Summary
.../status-widget-container.tsx Added a slug prop "documenso-status" to StatusWidget within a Suspense component.
.../status-widget.tsx Reordered imports, transformed StatusWidget into a memoized component accepting a slug prop, and adjusted related logic.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the apps: marketing Issues related to website or marketing app label Apr 10, 2024
@Mythie
Copy link
Collaborator

Mythie commented Apr 10, 2024

Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA:

https://documen.so/cla

@ElTimuro
Copy link
Member

image

Copy link

vercel bot commented Apr 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2024 3:41pm

Copy link
Member

@ElTimuro ElTimuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked locally and on preview
  • Does not solve completly, but reduced the infinite calls to when scrolling on the widget before it's done
  • Merging since incrementally better, stil looking for actual fix @thibaultleouay
  • Thank for your contribution in any case 🫡❤️

@ElTimuro ElTimuro merged commit a311869 into documenso:main Apr 10, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: marketing Issues related to website or marketing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants