Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add document log page link #1099

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

dguyen
Copy link
Collaborator

@dguyen dguyen commented Apr 11, 2024

Description

Adds a link from the document page view to the document page log view

image

Copy link
Contributor

coderabbitai bot commented Apr 11, 2024

Walkthrough

This update introduces a new feature to the DocumentPageViewDropdown component within the web application's dashboard. A ScrollTextIcon is now incorporated into the dropdown menu, enhancing navigation by providing a direct link to the document logs. This change aims to improve user experience by making document-related information more accessible.

Changes

File Path Change Summary
apps/web/src/app/.../document-page-view-dropdown.tsx Added ScrollTextIcon from 'lucide-react' to navigate to document logs.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between fe1f0e6 and 13cb019.
Files selected for processing (1)
  • apps/web/src/app/(dashboard)/documents/[id]/document-page-view-dropdown.tsx (2 hunks)
Additional comments not posted (1)
apps/web/src/app/(dashboard)/documents/[id]/document-page-view-dropdown.tsx (1)

118-123: Ensure accessibility for the new document logs link.

Consider adding aria-label to the Link component to improve accessibility. This label could describe the action, such as "View document logs", which would be helpful for screen reader users.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2024 5:21am
stg-marketing ✅ Ready (Inspect) Visit Preview Apr 11, 2024 5:21am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Apr 11, 2024 5:21am
prd-marketing ⬜️ Ignored (Inspect) Apr 11, 2024 5:21am

Copy link

Thank you for following the naming conventions for pull request titles! 💚🚀

@github-actions github-actions bot added the apps: web Issues related to the webapp label Apr 11, 2024
@dguyen dguyen merged commit 7705dba into main Apr 11, 2024
15 checks passed
@dguyen dguyen deleted the feat/add-document-log-page-link branch April 11, 2024 08:04
@ElTimuro
Copy link
Member

Planning to PR "Audit Log" as label, but that's not a critical change :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants