chore: added filename extension check

[adithyaakrishna]

Description:

This PR adds a check for filename title and if the title ends with .pdf then the extension isnt added or else its added

Summary by CodeRabbit

• Bug Fixes
  • Enhanced email attachment handling to ensure PDF files are correctly identified with a ".pdf" extension.

[coderabbitai]

Walkthrough

The recent system update focuses on refining the email sending process. Specifically, the adjustment ensures attachment filenames in completed emails end with ".pdf" for consistency. This enhancement streamlines document handling within the system.

Changes

File Path	Change Summary
.../send-completed-email.ts	Appends ".pdf" to the attachment filename if it does not already end with it.

---

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 1126fe4 and f8ddb0f.

Files selected for processing (1)

• packages/lib/server-only/document/send-completed-email.ts (2 hunks)

Files skipped from review as they are similar to previous changes (1)

• packages/lib/server-only/document/send-completed-email.ts

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
stg-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 0:51am
stg-marketing	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 18, 2024 0:51am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
prd-app	⬜️ Ignored (Inspect)			Apr 18, 2024 0:51am
prd-marketing	⬜️ Ignored (Inspect)			Apr 18, 2024 0:51am

[ElTimuro]

• @adithyaakrishna any idea why this happens in the first place? This fix is good for now, but i would like to know why
• Edit: I saw you mentioned they uploaded without pdf

[adithyaakrishna]

@ElTimuro This usually happens if the user uploads a PDF file For example, Adi.pdf which they renamed it to Adi without the .pdf extension at last. Our app shows the preview but the sendEmail functionality which has the filename didnt have a check for the extension and if a file sent without the extension in its filename, Gmail cant determine the filetype so it showed the blue file icon on the users received email. To fix that, I added the filename extension check in this PR

Please Lmk I wasnt clear or if you have any other doubts and I'll add a short video for reproducing this issue :)

[ElTimuro]

@ElTimuro This usually happens if the user uploads a PDF file For example, Adi.pdf which they renamed it to Adi without the .pdf extension at last. Our app shows the preview but the sendEmail functionality which has the filename didnt have a check for the extension and if a file sent without the extension in its filename, Gmail cant determine the filetype so it showed the blue file icon on the users received email. To fix that, I added the filename extension check in this PR

Please Lmk I wasnt clear or if you have any other doubts and I'll add a short video for reproducing this issue :)

• no pretty clear
• Though weird that people would do that (user do crazy stuff but stil)
• I always assumed it was sth. related to "." in the filename breaking the parsing or sth.
• Anyhow, will test and merge this

[ElTimuro]

@adithyaakrishna i approved you can just merge