-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: github repo management improvement #728
Conversation
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Someone is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
Signed-off-by: Adithya Krishna <adi@documenso.com>
.github/workflows/stale.yml
Outdated
stale-pr-message: 'This PR has not seen activitiy for a while. It will be closed in 30 days unless further activity is detected.' | ||
close-issue-message: 'This issue has been closed because of inactivity.' | ||
close-pr-message: 'This PR has been closed because of inactivity.' | ||
exempt-pr-labels: 'WIP, on-hold, needs review' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was about to write a whole thing but then I saw this, does the same exist for issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mythie This is both for issues and PRs, tho I haven't written explicit conditions for issues here. Do we need it for issues, if so, will update the workflow :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I'd use the same labels + roadmap
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
Signed-off-by: Adithya Krishna <adi@documenso.com>
.github/workflows/pr-labeler.yml
Outdated
@@ -9,6 +9,7 @@ concurrency: | |||
|
|||
jobs: | |||
labeler: | |||
if: github.repository == 'documenso/documenso' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of these now, seems strange 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific reason, as PRs will always be raised against our repo so we are restricting the workflow for our repo only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd toss them, they smell to me 👍
Signed-off-by: Adithya Krishna <adi@documenso.com>
.github/workflows/ci.yml
Outdated
@@ -16,15 +16,16 @@ env: | |||
jobs: | |||
build_app: | |||
name: Build App | |||
if: github.repository == 'documenso/documenso' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Mythie added the condition here as we will always run this workflow in our repo only, but if its not needed I will go ahead and remove it 😶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to run it on forks as well when a PR is created so I'd remove it
jobs: | ||
welcome-message: | ||
name: Welcome Contributors | ||
if: github.repository == 'documenso/documenso' && github.event.action == 'opened' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing here for PR's afaik
if: ${{ github.event.issue.assignee }} && github.repository == 'documenso/documenso' && github.event.action == 'assigned' && github.event.sender.type == 'User' | ||
runs-on: ubuntu-latest | ||
env: | ||
MY_ENV_VARIABLE: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔
Description: