Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: used constant for steps instead of strings #751

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

plxity
Copy link
Contributor

@plxity plxity commented Dec 10, 2023

fixes #750

Copy link

vercel bot commented Dec 10, 2023

@plxity is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Dec 10, 2023

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added the apps: marketing Issues related to website or marketing app label Dec 10, 2023
Copy link

github-actions bot commented Dec 10, 2023

Thank you for following the naming conventions for pull request titles! 💚🚀

@plxity plxity changed the title Used constant for steps instead of strings refactor: used constant for steps instead of strings Dec 10, 2023
@Mythie
Copy link
Collaborator

Mythie commented Dec 10, 2023

Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA:

https://documen.so/cla

@plxity
Copy link
Contributor Author

plxity commented Dec 11, 2023

@Mythie Done

@plxity
Copy link
Contributor Author

plxity commented Dec 12, 2023

@Mythie Please review this whenever you are available.

@catalinpit catalinpit merged commit 83dfe92 into documenso:main Dec 15, 2023
3 of 7 checks passed
@catalinpit
Copy link
Contributor

Thanks for the PR! Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: marketing Issues related to website or marketing app
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use constants instead of strings in the step involved inside widget component
3 participants