Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webapp): reset delete document dialog #762

Merged
merged 6 commits into from
Dec 22, 2023
Merged

Conversation

ubinatus
Copy link
Contributor

@ubinatus ubinatus commented Dec 15, 2023

This PR makes a small but useful tweak to the DeleteDocumentDialog. Now, the input field gets cleared whenever the dialog is opened. Here’s what’s changed:

  1. Clear Field After Deleting: After you delete something and open the dialog again, it won’t show the old, deleted text anymore. It’s clean and ready for the next delete.

  2. Type Again to Confirm: If you type something but close the dialog without deleting, you’ll have to type it again next time. This way, it makes sure the user really mean to delete something and didn't do it by mistake.

Demo Link:
See the old vs. new in action here: https://www.loom.com/share/80eca0d3b1994f7cbcab6f222db2dbfe?sid=ebc6135c-345e-4640-b395-daff190a96e7

It’s a small change, but it makes the delete process safer and smoother.

Copy link

vercel bot commented Dec 15, 2023

@ubinatus is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Dec 15, 2023

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can reply to a review comment made by CodeRabbit.
  • You can tag CodeRabbit on specific lines of code or files in the PR by tagging @coderabbitai in a comment.
  • You can tag @coderabbitai in a PR comment and ask one-off questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

@github-actions github-actions bot added the apps: web Issues related to the webapp label Dec 15, 2023
@Mythie
Copy link
Collaborator

Mythie commented Dec 15, 2023

Hey there, it looks like you haven't accepted our contributor license agreement yet. In order for us to accept your pull request we ask that you please fill out the CLA:

https://documen.so/cla

@catalinpit
Copy link
Contributor

Hey @ubinatus, thanks for the PR! The demo link doesn't work. Could you update the link, please?

@ubinatus
Copy link
Contributor Author

Hi @catalinpit! I've updated the description with a working public loom url. Sorry about that, it was toggled as a private link.

@catalinpit
Copy link
Contributor

Hi @catalinpit! I've updated the description with a working public loom url. Sorry about that, it was toggled as a private link.

Hey, thank you! In the meanwhile, I tested the changes and I came across an issue. If you try to delete a draft document, the delete button is disabled. See the attached pic.

CleanShot 2023-12-19 at 10 57 19

That's because in the useEffect we set isDeleteEnabled to false, even if the document is a draft. Perhaps, we should do a check to see if the status of the document is set to draft before setting isDeleteEnabled to false? Just an idea. 👀

catalinpit
catalinpit previously approved these changes Dec 20, 2023
Copy link
Contributor

@catalinpit catalinpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the work!

useEffect(() => {
if (open) {
setInputValue('');
setIsDeleteEnabled(status === DocumentStatus.DRAFT ? true : false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can just be:

setIsDeleteEnabled(status === DocumentStatus.DRAFT);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! No need for that ternary. Done!

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 22, 2023 2:43am

@ubinatus ubinatus requested a review from dguyen December 22, 2023 03:05
Copy link
Collaborator

@dguyen dguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 😃

@dguyen dguyen merged commit 5a5d00f into documenso:main Dec 22, 2023
9 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants