-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show document title for delete dialog - [DOC-387] #772
Conversation
Signed-off-by: Adithya Krishna <adi@documenso.com>
Someone is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
Signed-off-by: Adithya Krishna <adi@documenso.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We should also display the title within the dialog rather than just the resulting toast notification as well, otherwise you're going to learn that you deleted the wrong document after the fact. |
@Mythie How abt if we put it in a code block for the file name? or should we put it in double quotes? |
Signed-off-by: Adithya Krishna <adi@documenso.com>
I would use quotes and do without the extra colour since it makes it look like a link 😄 |
apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx
Outdated
Show resolved
Hide resolved
apps/web/src/app/(dashboard)/documents/delete-document-dialog.tsx
Outdated
Show resolved
Hide resolved
@@ -81,7 +92,7 @@ export const DeleteDocumentDialog = ({ | |||
</DialogHeader> | |||
|
|||
{status !== DocumentStatus.DRAFT && ( | |||
<div className="mt-8"> | |||
<div className="mt-4"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also felt the same, one of the previous PRs introduced the mt-8
and I felt the margin was too huge as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be me, I like having the action buttons separated from any kind of input/form elements to assist with misclicking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the example above, it doesn't seem like it would be easy to misclick. Or am I missing something? 👀
@adithyaakrishna The phrasing is a bit bulky, I'd prefer sth. like "Do you want to delete XXXX" or "Do you want to delete the document XXXXX" |
Description: