fix: hotkeys was overlapping with the browser hotkeys #774
Conversation
Signed-off-by: harkiratsm <multaniharry714@gmail.com>
|
@harkiratsm is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
|
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ? TipsChat with CodeRabbit Bot (
|
| @@ -85,7 +85,8 @@ export function CommandMenu({ open, onOpenChange }: CommandMenuProps) { | |||
|
|
|||
| const currentPage = pages[pages.length - 1]; | |||
|
|
|||
| const toggleOpen = () => { | |||
| const toggleOpen = (e: KeyboardEvent) => { | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Makes sense, does stopPropogation or stopImmediateProprogation also work?
There was a problem hiding this comment.
No, it is not effective in this case because we are attempting to prevent the browser's default behaviour.
There was a problem hiding this comment.
Sweet, lets roll with this then!
|
LGTM! Welcome to Documenso Harkirat 🎉
|
Issue - The
Ctrl+Khotkey in our application is conflicting with the browser's default search hotkey, leading to unintended browser actions.docu.mov