Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added constants for theme variables #777

Merged
merged 2 commits into from
Dec 25, 2023

Conversation

plxity
Copy link
Contributor

@plxity plxity commented Dec 21, 2023

fixes: #776

Copy link
Contributor

coderabbitai bot commented Dec 21, 2023

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on X ?


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Use quoted replies to pass the context for follow-up questions. Examples:
    • @coderabbitai render interesting statistics about this repository as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai generate unit tests for the src/utils.ts file.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

vercel bot commented Dec 21, 2023

@plxity is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Dec 21, 2023

Thank you for following the naming conventions for pull request titles! 💚🚀

@plxity plxity changed the title fix: added constants for themes fix: added constants for theme variables Dec 21, 2023
@dguyen
Copy link
Collaborator

dguyen commented Dec 22, 2023

@github-actions github-actions bot added the apps: web Issues related to the webapp label Dec 22, 2023
@plxity plxity force-pushed the feat/use-constants-for-theme branch from ffca0fb to a489471 Compare December 22, 2023 07:19
@plxity
Copy link
Contributor Author

plxity commented Dec 22, 2023

@dguyen done!

@plxity
Copy link
Contributor Author

plxity commented Dec 25, 2023

@catalinpit Please review this change

@Mythie
Copy link
Collaborator

Mythie commented Dec 25, 2023

Hey Apoorv, most of the Documenso team are on break over the next couple of days due to many upcoming National Holidays.

We’ll be with you when we can, until then please avoid tagging team members 🙌🏻

@plxity
Copy link
Contributor Author

plxity commented Dec 25, 2023

Apologies @Mythie! Happy holidays 🎉

Copy link
Collaborator

@dguyen dguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 🙂

@dguyen dguyen merged commit 5a32b5c into documenso:main Dec 25, 2023
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using constant for theme instead of direct values ("light", "dark", "system")
3 participants