Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve conflicting z-index values #788

Merged
merged 2 commits into from
Dec 28, 2023
Merged

fix: resolve conflicting z-index values #788

merged 2 commits into from
Dec 28, 2023

Conversation

dguyen
Copy link
Collaborator

@dguyen dguyen commented Dec 27, 2023

Description

Currently there are various z-index values that are causing:

  • Toasts to be placed behind dialog blur background
  • Menu being cropped off by header

Changes Made

  • Revert z-[1000] back to z-50 for the header (not exactly sure why it was bumped)
  • Refactor z-indexes over 9000 to start from 1000
  • Ensure z-index of toast is higher than dialog

Testing Performed

Mobile toast is on top

image

Toast is in-front of blurred dialog background
image

Dropdown is no longer being cropped off

image

Checklist

  • I have tested these changes locally and they work as expected.

Copy link
Contributor

coderabbitai bot commented Dec 27, 2023

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • You can directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 7:15am
stg-marketing ❌ Failed (Inspect) Dec 28, 2023 7:15am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 7:15am
prd-marketing ⬜️ Ignored (Inspect) Dec 28, 2023 7:15am

@github-actions github-actions bot added the apps: web Issues related to the webapp label Dec 27, 2023
@dguyen
Copy link
Collaborator Author

dguyen commented Dec 28, 2023

Having the dialog at 1000 will probably cause issues with any sub elements that rely in z-index.

@dguyen dguyen merged commit 3f89f87 into main Dec 28, 2023
12 of 13 checks passed
@dguyen dguyen deleted the fix/z-index-ordering branch December 28, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants