Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): cache github workflow actions #804

Merged
merged 26 commits into from
Mar 4, 2024
Merged

Conversation

G3root
Copy link
Contributor

@G3root G3root commented Jan 4, 2024

No description provided.

Copy link

vercel bot commented Jan 4, 2024

@G3root is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jan 4, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@G3root G3root marked this pull request as draft January 4, 2024 19:18
@G3root G3root marked this pull request as ready for review January 4, 2024 20:57
adithyaakrishna
adithyaakrishna previously approved these changes Jan 5, 2024
Copy link
Member

@adithyaakrishna adithyaakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G3root This would be a good improvement to the CI, I was planning to cache the build artifact yesterday and I guess it's been implemented already

@@ -0,0 +1,29 @@
name: cleanup caches by a branch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the apps: web Issues related to the webapp label Jan 6, 2024
@@ -47,5 +37,31 @@ jobs:
with:
fetch-depth: 2

- name: Set up Docker Buildx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mythie
Copy link
Collaborator

Mythie commented Jan 10, 2024

I thought that the npm cache was already satisfactory? Was I wrong in that assumption 🤔

Work looks really good either way, although I wonder what the cost of this will look like 👀

@adithyaakrishna
Copy link
Member

If I am not wrong, I guess we would be using a built version of Documenso instead of rebuilding it again and again unless code stuff has changed. Along with this, I guess we would also be caching node_modules in a better way. Overall this may give us a slight advantage in terms of the CI timings

CC @G3root

@G3root
Copy link
Contributor Author

G3root commented Jan 18, 2024

If I am not wrong, I guess we would be using a built version of Documenso instead of rebuilding it again and again unless code stuff has changed. Along with this, I guess we would also be caching node_modules in a better way. Overall this may give us a slight advantage in terms of the CI timings

CC @G3root

yeah, we can go with that approach, but I believe it carries some risk because Changes in environment variables could affect the build output. Or, we can try experimenting with TurboRepo to manage the cache. https://turbo.build/repo/docs/ci/github-actions#caching-with-github-actionscache

@Mythie
Copy link
Collaborator

Mythie commented Feb 24, 2024

Sorry for the delay, approving but delaying merging for the moment since I'd like to limit some blast radius.

/remindme 1 week

@Mythie Mythie merged commit f6f9c30 into documenso:main Mar 4, 2024
8 of 12 checks passed
@G3root G3root deleted the cache-workflow branch March 5, 2024 00:28
@Mythie
Copy link
Collaborator

Mythie commented Mar 8, 2024

/tip 150

The work is much appreciated by the way 😄

Copy link

algora-pbc bot commented Mar 8, 2024

🎉🎈 @G3root has been awarded $150! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

3 participants