-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jump to next field #805
Conversation
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
I think the button shouldn't be called Also the button should probably stay as the default variant in my opinion |
+1 for both pieces of feedback 😄 |
Thanks for the feedback! I implemented both things, although, I must say it feels a bit weird (personally) to have the button green before you can complete the signing. But if this is the consensus, I'll abide it. 😆 |
Fixes #710
When the fields are not filled, the button will have the
outline
variant and it'll say "Fill fields". Clicking on the button takes you to the unfilled field.Once all fields are filled, the button will be green and it'll say "Complete".
Created the PR to move faster and ship the changes asap.
PR based on these PRs:
Thank you for the work, folks!