Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix color for light mode icon #806

Merged
merged 2 commits into from
Jan 14, 2024
Merged

chore: fix color for light mode icon #806

merged 2 commits into from
Jan 14, 2024

Conversation

adithyaakrishna
Copy link
Member

Description:

I saw the below minor nitpick in the them-switcher component. Fixed it with this PR

Screenshot 2024-01-05 at 18 19 23

chore: fix color for light mode icon
0090f3e 
Signed-off-by: Adithya Krishna <adi@documenso.com>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 5, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit's AI:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
    • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@adithyaakrishna adithyaakrishna self-assigned this Jan 5, 2024
@vercel Vercel
Copy link

vercel bot commented Jan 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 1:01pm
stg-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 5, 2024 1:01pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 1:01pm
prd-marketing ⬜️ Ignored (Inspect) Jan 5, 2024 1:01pm

chore: blog typos fix
005f45d 
Signed-off-by: Adithya Krishna <adi@documenso.com>
@github-actions github-actions bot added the apps: marketing Issues related to website or marketing app label Jan 5, 2024
@adithyaakrishna
Copy link
Member Author

Plus fixed some typos which I had come across 😶

catalinpit
catalinpit reviewed Jan 5, 2024
View reviewed changes
packages/ui/primitives/theme-switcher.tsx
@@ -18,7 +18,7 @@ export const ThemeSwitcher = () => {
>
{isMounted && theme === THEMES_TYPE.LIGHT && (
<motion.div
className="bg-background absolute inset-0 rounded-full mix-blend-exclusion"
className="bg-background absolute inset-0 rounded-full mix-blend-color-burn"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SYSTEM still has mix-blend-exclusion. Is this change intended only for the LIGHT icon?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of changing the mix-blend for just one icon, the optimal solution would be to play around with z-index, we can remove mix-blend-exculsion from all the divs and give all the SVG a higher z-index than the div which is circling the SVG in the active state. That would fix it for all the icons.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense, I will send an update for that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't do that, the mix blend mode hack is a trick for framer motion animations. See: https://www.youtube.com/watch?v=kep_Iaxuzy0

@dguyen dguyen merged commit 58b3a12 into main Jan 14, 2024
13 checks passed
@dguyen dguyen deleted the chore/switch-colors branch January 14, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catalinpit catalinpit catalinpit left review comments

@plxity plxity plxity left review comments

@Mythie Mythie Mythie approved these changes

Assignees

@adithyaakrishna adithyaakrishna

Labels
apps: marketing Issues related to website or marketing app
Projects
No open projects
Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adithyaakrishna @Mythie @catalinpit @plxity @dguyen