Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sign up with Google #862

Merged
merged 6 commits into from
Jan 25, 2024

Conversation

suryapts007
Copy link
Contributor

@suryapts007 suryapts007 commented Jan 23, 2024

This PR links to this issue: #791
Now users can see a new option to sign up with Google on the signup page.

Screenshots (Sing In Page):
Screenshot 2024-01-24 at 2 17 49 AM
Screenshot 2024-01-24 at 2 18 19 AM

Screenshots (Sing Up Page):
Screenshot 2024-01-24 at 2 19 04 AM
Screenshot 2024-01-24 at 2 19 26 AM

Copy link

vercel bot commented Jan 23, 2024

@suryapts007 is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Jan 23, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

github-actions bot commented Jan 23, 2024

Thank you for following the naming conventions for pull request titles! 💚🚀

@github-actions github-actions bot added the apps: web Issues related to the webapp label Jan 23, 2024
@suryapts007 suryapts007 changed the title Singup with Google feat: Singup with Google Jan 23, 2024
@dguyen dguyen changed the title feat: Singup with Google feat: sign up with Google Jan 24, 2024
apps/web/src/components/forms/signup.tsx Show resolved Hide resolved
@@ -221,7 +221,7 @@ export const SignInForm = ({ className, isGoogleSSOEnabled }: SignInFormProps) =
onClick={onSignInWithGoogleClick}
>
<FcGoogle className="mr-2 h-5 w-5" />
Google
Sign In with Google
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert the changes in this file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sure. Done with it.

Though, would like to know the idea behind keeping it same.

@anikdhabal
Copy link
Contributor

Hey @dguyen in the Pr #727 I've fixed this one also.

@dguyen
Copy link
Collaborator

dguyen commented Jan 24, 2024

@anikdhabal thanks but I'm not sure that PR is going anywhere anytime soon due to the Apple setup required

@anikdhabal
Copy link
Contributor

@anikdhabal thanks but I'm not sure that PR is going anywhere anytime soon due to the Apple setup required

Yeah, that's true. Okay, then I will make sure to change that PR before merging according to the changes.

Copy link
Collaborator

@dguyen dguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for this :)

@dguyen dguyen merged commit 11dd934 into documenso:main Jan 25, 2024
8 of 12 checks passed
@dguyen dguyen linked an issue Jan 28, 2024 that may be closed by this pull request
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Issues related to the webapp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to Singup with Google on signup page
3 participants