Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add server crypto #863

Merged
merged 2 commits into from
Jan 25, 2024
Merged

feat: add server crypto #863

merged 2 commits into from
Jan 25, 2024

Conversation

dguyen
Copy link
Collaborator

@dguyen dguyen commented Jan 24, 2024

Description

Currently we are required to ensure PII data is not passed around in search parameters and in the open for GDPR reasons.

Allowing us to encrypt and decrypt values with expiry dates will allow us to ensure this doesn't happen.

Changes Made

  • Added TPRC router for encryption and decryption methods

Testing Performed

  • Tested encrypting and decrypting data with and without expiredAt
  • Tested via directly accessing API and also via trpc in react components
  • Tested parsing en email search param in a page and decrypting it successfully

Checklist

  • I have tested these changes locally and they work as expected.
  • I have followed the project's coding style guidelines.

Copy link
Contributor

coderabbitai bot commented Jan 24, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 0:17am
stg-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 25, 2024 0:17am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Jan 25, 2024 0:17am
prd-marketing ⬜️ Ignored (Inspect) Jan 25, 2024 0:17am

packages/trpc/server/crypto/router.ts Outdated Show resolved Hide resolved
packages/lib/server-only/crypto/encrypt.ts Outdated Show resolved Hide resolved
packages/lib/server-only/crypto/decrypt.ts Outdated Show resolved Hide resolved
packages/lib/constants/crypto.ts Show resolved Hide resolved
@dguyen dguyen merged commit d766b58 into main Jan 25, 2024
8 of 12 checks passed
@dguyen dguyen deleted the feat/encryption branch January 25, 2024 05:07
Copy link
Contributor

@catalinpit catalinpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

packages/lib/constants/crypto.ts Show resolved Hide resolved
packages/lib/constants/crypto.ts Show resolved Hide resolved
packages/lib/server-only/crypto/decrypt.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants