Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add user security audit logs #884

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

dguyen
Copy link
Collaborator

@dguyen dguyen commented Jan 30, 2024

Description

Adds the ability to see the events relating to the account.

Event data includes:

  • Device
  • IP Address
  • Time
  • Action

Actions are:

  • Profile update
  • Account linked to SSO (Example user signs in with Google after creating a email/password account)
  • Enable 2FA
  • Disable 2FA
  • Reset password
  • Update password
  • Sign out
  • Sign in
  • Sign in fail
  • Sign in 2FA fail

Changes

  • Added audit logs
  • Updated 2FA dialogs to have consistent footers
  • Update /settings/security/page layout

Testing Performed

Tested events:

image

More tested events:

image

Checklist

  • I have tested these changes locally and they work as expected.
  • I have followed the project's coding style guidelines.

Additional Notes

  • Not sure if we really want to record the sign out event or not
  • Might want to design breadcrumbs for nested setting pages

Copy link

vercel bot commented Jan 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stg-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:30am
stg-marketing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 1:30am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
prd-app ⬜️ Ignored (Inspect) Jan 31, 2024 1:30am
prd-marketing ⬜️ Ignored (Inspect) Jan 31, 2024 1:30am

Copy link
Contributor

coderabbitai bot commented Jan 30, 2024

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@@ -1,41 +1,54 @@
import * as React from 'react';
Copy link
Collaborator Author

@dguyen dguyen Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alert changes extracted from the teams PR

@@ -2,36 +2,53 @@

Copy link
Collaborator Author

@dguyen dguyen Jan 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table changes extracted from the teams PR

Copy link
Collaborator

@Mythie Mythie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
lgtm-yugi

@Mythie Mythie merged commit e42088a into main Feb 1, 2024
12 of 14 checks passed
@Mythie Mythie deleted the feat/add-user-security-audit-logs branch February 1, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants