-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove document on go back click on step 1 #910
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
37e9db6
Remove document on go back click on step 1
prajwalkulkarni c08768a
Format code with prettier
prajwalkulkarni 4855882
Update label render condition
prajwalkulkarni 5391dd9
Merge branch 'main' into reattach-pdf
prajwalkulkarni d5867ae
Merge branch 'main' into reattach-pdf
prajwalkulkarni a58a117
Merge branch 'main' into reattach-pdf
prajwalkulkarni 870de02
Merge branch 'main' into reattach-pdf
prajwalkulkarni 04ebb26
chore: update wording
Mythie 805758f
Merge branch 'main' into reattach-pdf
Mythie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't work since it would also affect the main webapp where the document wouldn't be removed 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a global lookup of where all
AddFieldsFormPartial
is used and it looks like it is used only in singleplayermode andedit-document.tsx
which is a part of main webapp dashboard. The propertydocumentFlow.fields
inedit-document.tsx
doesn't have theonBackStep
property implemented, meaningtypeof documentFlow.onBackStep
would be falsy, thereby the default fallback string would be rendered (Please correct me If I'm wrong here). Nonetheless, I've made the changes by adding an additional optional prop to theAddFieldsFormPartial
component to keep it future-proof. Kindly check.