Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove document on go back click on step 1 #910

Merged
merged 9 commits into from
May 24, 2024
Merged

fix: Remove document on go back click on step 1 #910

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
37e9db6
Remove document on go back click on step 1
prajwalkulkarni Feb 5, 2024
c08768a
Format code with prettier
prajwalkulkarni Feb 6, 2024
4855882
Update label render condition
prajwalkulkarni Feb 7, 2024
5391dd9
Merge branch 'main' into reattach-pdf
prajwalkulkarni Feb 8, 2024
d5867ae
Merge branch 'main' into reattach-pdf
prajwalkulkarni Feb 9, 2024
a58a117
Merge branch 'main' into reattach-pdf
prajwalkulkarni Feb 23, 2024
870de02
Merge branch 'main' into reattach-pdf
prajwalkulkarni Mar 1, 2024
04ebb26
chore: update wording
Mythie May 24, 2024
805758f
Merge branch 'main' into reattach-pdf
Mythie May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/ui/primitives/document-flow/add-fields.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -566,7 +566,13 @@ export const AddFieldsFormPartial = ({
onGoBackClick={() => {
previousStep();
remove();
documentFlow.onBackStep?.();
}}
goBackLabel={
currentStep === 1 && typeof documentFlow.onBackStep === 'function'
? 'Remove'
: undefined
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't work since it would also affect the main webapp where the document wouldn't be removed 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a global lookup of where all AddFieldsFormPartial is used and it looks like it is used only in singleplayermode and edit-document.tsx which is a part of main webapp dashboard. The property documentFlow.fields in edit-document.tsx doesn't have the onBackStep property implemented, meaning typeof documentFlow.onBackStep would be falsy, thereby the default fallback string would be rendered (Please correct me If I'm wrong here). Nonetheless, I've made the changes by adding an additional optional prop to the AddFieldsFormPartial component to keep it future-proof. Kindly check.

onGoNextClick={() => void onFormSubmit()}
/>
</DocumentFlowFormContainerFooter>
Expand Down