-
Notifications
You must be signed in to change notification settings - Fork 817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: table layout shift while changing tabs #921
Conversation
@plxity is attempting to deploy a commit to the Documenso Team Team on Vercel. A member of the Team first needs to authorize it. |
@dguyen Please review this PR |
Thank you for following the naming conventions for pull request titles! 💚🚀 |
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Please don't ping maintainers directly unless the PR is stale, we actively monitor the issues and PRs and will get around to them when possible |
Noted. |
style={{ | ||
width: cell.column.getSize(), | ||
}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have to assume that this is covered by specifying the size already, is that not the case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get your question, can you elaborate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that tanstack table is already setting the width of the column using cell.column.getSize()
so doing so in the style attribute here should be redundant.
Instead we should only need the manually specified size change that you had in the other part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, So are you suggesting to hardcode the width in this file?
@Mythie Can you review this one? |
Cheers Apoorv! 😄 |
fixes: #875
Screen.Recording.2024-02-08.at.1.31.12.PM.mov