feat: add document page view #926
Conversation
|
Important Auto Review SkippedAuto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you for following the naming conventions for pull request titles! 💚🚀 |
| const documentInformation = useMemo(() => { | ||
| let createdValue = DateTime.fromJSDate(document.createdAt).toFormat('MMMM d, yyyy'); | ||
| let lastModifiedValue = DateTime.fromJSDate(document.updatedAt).toRelative(); | ||
|
|
||
| if (!isMounted) { | ||
| createdValue = DateTime.fromJSDate(document.createdAt) | ||
| .setLocale(locale) | ||
| .toFormat('MMMM d, yyyy'); | ||
|
|
||
| lastModifiedValue = DateTime.fromJSDate(document.updatedAt).setLocale(locale).toRelative(); | ||
| } | ||
|
|
||
| return [ | ||
| { | ||
| description: 'Uploaded by', | ||
| value: userId === document.userId ? 'You' : document.User.name ?? document.User.email, | ||
| }, | ||
| { | ||
| description: 'Created', | ||
| value: createdValue, | ||
| }, | ||
| { | ||
| description: 'Last modified', | ||
| value: lastModifiedValue, | ||
| }, | ||
| ]; | ||
| }, [isMounted, document, locale, userId]); |
There was a problem hiding this comment.
Seems like it'd just be easier to have three memo's or something rather than returning the array no?
There was a problem hiding this comment.
How come? 2/3 of the items require the same logic for locales
apps/web/src/app/(dashboard)/documents/[id]/document-page-view-recent-activity.tsx
Show resolved
Hide resolved
|
Note: Added feature flag which defaults to off for the document audit log sheet. |
|
lgtm
|
Description
This feature allows us to have a dedicated page to view details for a document.
The current
/documents/[id]page has been moved to/documents/[id]/edit.The new
/documents/[id]page will now display general information on the document itself.This will allow us to provide more details relating to a document in the future, such as version history.
Examples
These may be outdated as deployment failed
Login via example@documenso.com
Draft document no recipients:
https://stg-7hpkvyc5i-documenso.vercel.app/documents/446
Draft document with recipients:
https://stg-7hpkvyc5i-documenso.vercel.app/documents/440
Pending document:
https://stg-7hpkvyc5i-documenso.vercel.app/documents/447
Completed document:
https://stg-7hpkvyc5i-documenso.vercel.app/documents/448
Pending teams document:
https://stg-7hpkvyc5i-documenso.vercel.app/t/hello/documents/449/
Checklist
Additional Notes
When a user "sends" a document (DRAFT -> PENDING), should we redirect them to the document/id page, or keep it how it currently is and have it redirect to
/documentspage?