feat: Ability to send team invitation in bulk #930

anikdhabal · 2024-02-14T04:23:38Z

fixes #923

Documenso.and.5.more.pages.-.Personal.-.Microsoft_.Edge.2024-02-14.09-49-37.mp4

vercel · 2024-02-14T04:23:43Z

@anikdhabal is attempting to deploy a commit to the Documenso Team Team on Vercel.

A member of the Team first needs to authorize it.

coderabbitai · 2024-02-14T04:23:49Z

Important

Auto Review Skipped

Auto reviews are limited to the following labels: coderabbit. Please add one of these labels to enable auto reviews.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx

ElTimuro · 2024-02-14T09:07:43Z

@anikdhabal neat
What happends with invalid email?
A toast informing how many were successfully invite would be good, so the user does not have to count the resulting row in the memebers table

anikdhabal · 2024-02-14T09:33:41Z

@anikdhabal neat

What happends with invalid email?

A toast informing how many were successfully invite would be good, so the user does not have to count the resulting row in the memebers table

Thanks for your review and suggestion.

Yeah, the code handles invalid email addresses. It simply shows the error message 'invalid email' in both cases.

Mythie · 2024-02-14T11:07:21Z

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx

+
+    if (file) {
+      const reader = new FileReader();
+      const emailRegex = /^([A-Z0-9_+-]+\.?)*[A-Z0-9_+-]@([A-Z0-9][A-Z0-9-]*\.)+[A-Z]{2,}$/i;


Could we not use zod here?

Yeah, we are also using Zod here. We can remove this.

Mythie · 2024-02-14T11:07:51Z

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx

+    if (file) {
+      const reader = new FileReader();
+      const emailRegex = /^([A-Z0-9_+-]+\.?)*[A-Z0-9_+-]@([A-Z0-9][A-Z0-9-]*\.)+[A-Z]{2,}$/i;
+      reader.onload = (e) => {


This is a bit scary, things like papaparse and such exist for handling the reading of CSV files in a safe manner since the format itself is prone to weirdness.

Thanks for the suggestion. Papaparse would be good for handling csv file.

Consider the bundle size implications as well there may be smaller and just as good options 😄 Papaparse was the most popular last I messed with CSV's but I'm unsure as to what current recommendations are.

https://bundlephobia.com/ is a fantastic website for seeing how big something might be!

Okay😄. Let me check this out.

Mythie · 2024-02-14T11:08:31Z

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx

-          role: TeamMemberRole.MEMBER,
-        },
-      ],
+      email: '' || [''],


Seems it would be easier to always make this an array of emails so we don't have to deal with unions. I assume in the UI you would have an option to "Add another member" within the form.

dguyen · 2024-02-15T01:05:00Z

Some thoughts just by looking at the loom (haven't looked at the code)

The default tab should be individual
Keep the old functionality prior to this PR where multiple users can be invited as the 'individual' tab
Instead of directly inviting bulk bulk team members, I think we should also allow the user to "Review" it (optional) by loading it into the individual section so they can review and change selected roles

anikdhabal · 2024-02-15T21:26:46Z

Documenso.and.8.more.pages.-.Personal.-.Microsoft_.Edge.2024-02-16.02-50-11.mp4

Thoughts on this? Instead of sending invites from the bulk import section, we use it for importing emails and then redirect to the invite member page, where we can change the selected role before sending the invite.

Or,

Users can send invitations from both sides, just like the current changes.

harkiratsm · 2024-02-18T10:49:52Z

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx

@@ -151,80 +175,123 @@ export const InviteTeamMembersDialog = ({
            An email containing an invitation will be sent to each member.
          </DialogDescription>
        </DialogHeader>
-
+        <div className="border-input ring-offset-background flex w-full justify-around rounded-md border">


We could have used the Tabs component here. 💭

Mythie · 2024-02-24T11:58:05Z

Documenso.and.8.more.pages.-.Personal.-.Microsoft_.Edge.2024-02-16.02-50-11.mp4
Thoughts on this? Instead of sending invites from the bulk import section, we use it for importing emails and then redirect to the invite member page, where we can change the selected role before sending the invite.

Or,

Users can send invitations from both sides, just like the current changes.

If we're doing this I'd avoid the text input and just have it only accept CSV where it'll be in email,role format so we can toss a bunch of ui elements.

We should also supply a template csv which would look like:

email,role
john@example.com,SIGNER

Seems crazy but in the past many clients have wanted the template to work off 😄

So to clarify:

For the bulk import tab, make it only two buttons. One for importing and one for downloading a template for the import.
Imported items can go to the other tab for modification as the user sees fit.

anikdhabal · 2024-04-03T19:46:54Z

dguyen

Looks good to me, thanks!

feat: bulk imports

298db59

github-actions bot added the apps: web Issues related to the webapp label Feb 14, 2024

github-advanced-security bot found potential problems Feb 14, 2024

View reviewed changes

apps/web/src/components/(teams)/dialogs/invite-team-member-dialog.tsx Fixed Show fixed Hide fixed

Mythie reviewed Feb 14, 2024

View reviewed changes

Merge branch 'main' into issue#923

4d4edc8

harkiratsm reviewed Feb 18, 2024

View reviewed changes

anikdhabal and others added 2 commits April 4, 2024 01:05

Merge branch 'main' into issue#923

3ccc7b1

feat: bulk imports

b03efcf

github-actions bot added the version bump 👀 label Apr 3, 2024

feat: bulk import

03e7611

anikdhabal requested a review from Mythie April 3, 2024 19:47

anikdhabal and others added 3 commits April 4, 2024 11:21

Merge branch 'main' into issue#923

de6bd99

feat: bulk imports

a4ace81

fix: refactor

30bedee

dguyen approved these changes Apr 4, 2024

View reviewed changes

dguyen merged commit b871540 into documenso:main Apr 4, 2024
8 of 12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Ability to send team invitation in bulk #930

feat: Ability to send team invitation in bulk #930

anikdhabal commented Feb 14, 2024 •

edited

vercel bot commented Feb 14, 2024

coderabbitai bot commented Feb 14, 2024 •

edited

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (`.coderabbit.yaml`)

Documentation and Community

ElTimuro commented Feb 14, 2024

anikdhabal commented Feb 14, 2024

Mythie Feb 14, 2024

anikdhabal Feb 14, 2024

Mythie Feb 14, 2024

anikdhabal Feb 14, 2024 •

edited

Mythie Feb 14, 2024

anikdhabal Feb 14, 2024

Mythie Feb 14, 2024

dguyen commented Feb 15, 2024

anikdhabal commented Feb 15, 2024

harkiratsm Feb 18, 2024

Mythie commented Feb 24, 2024 •

edited

anikdhabal commented Apr 3, 2024

dguyen left a comment

feat: Ability to send team invitation in bulk #930

feat: Ability to send team invitation in bulk #930

Conversation

anikdhabal commented Feb 14, 2024 • edited

vercel bot commented Feb 14, 2024

coderabbitai bot commented Feb 14, 2024 • edited

Auto Review Skipped

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

ElTimuro commented Feb 14, 2024

anikdhabal commented Feb 14, 2024

Mythie Feb 14, 2024

Choose a reason for hiding this comment

anikdhabal Feb 14, 2024

Choose a reason for hiding this comment

Mythie Feb 14, 2024

Choose a reason for hiding this comment

anikdhabal Feb 14, 2024 • edited

Choose a reason for hiding this comment

Mythie Feb 14, 2024

Choose a reason for hiding this comment

anikdhabal Feb 14, 2024

Choose a reason for hiding this comment

Mythie Feb 14, 2024

Choose a reason for hiding this comment

dguyen commented Feb 15, 2024

anikdhabal commented Feb 15, 2024

harkiratsm Feb 18, 2024

Choose a reason for hiding this comment

Mythie commented Feb 24, 2024 • edited

anikdhabal commented Apr 3, 2024

dguyen left a comment

Choose a reason for hiding this comment

anikdhabal commented Feb 14, 2024 •

edited

coderabbitai bot commented Feb 14, 2024 •

edited

CodeRabbit Configration File (`.coderabbit.yaml`)

anikdhabal Feb 14, 2024 •

edited

Mythie commented Feb 24, 2024 •

edited