Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/ is outdated (still includes polyglot), so running fails #853

Closed
zacanger opened this issue Jul 27, 2017 · 4 comments
Closed

lib/ is outdated (still includes polyglot), so running fails #853

zacanger opened this issue Jul 27, 2017 · 4 comments

Comments

@zacanger
Copy link

zacanger commented Jul 27, 2017

Using documentation (from CLI, but I assume the API as well) fails on 5.0.0 because get-comments is not installed. That was an explicit dependency that was removed when polyglot was removed. It seems that the published version doesn't have a freshly build lib/ directory, which means the polyglot stuff is still there. To reproduce:

npm init -y && npm i documentation && ls node_modules/documentation/parsers you'll see polyglot still there, requiring get-comments.

A preversion (if you use npm version) or prepublishOnly script could handle automatically in the future.

@zacanger zacanger changed the title lib/ is outdated, so running fails lib/ is outdated (still includes polyglot), so running fails Jul 28, 2017
@tmcw
Copy link
Member

tmcw commented Jul 28, 2017

Ah, thanks for the report, publishing a 5.0.1 with a fix now.

I think in terms of release strategy, I definitely at least need to add build to prepublish.

@sudo-suhas
Copy link

That was literally a breaking change 😀

@zacanger
Copy link
Author

Thank you!

@tmcw
Copy link
Member

tmcw commented Jul 28, 2017

Reopening to associate with prepublish step.

@tmcw tmcw reopened this Jul 28, 2017
tmcw added a commit that referenced this issue Jul 28, 2017
@tmcw tmcw closed this as completed in 81fa4b0 Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants