-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external
option to allow whitelisting external dependencies
#60
Conversation
Issue: #56 |
@tmcw I think this is pretty much ready. |
@anandthakker are tests passing on your side? Getting a test failure with
|
@tmcw hmm, strange -- they're passing on my end... |
Factors all external module checking logic out to lib/external-module-filter.js
1f7d165
to
bea63f7
Compare
@tmcw note: just rebased. Still can't reproduce the test failure, and I'm puzzled at the one you're getting. Can you update |
Yep, I think all my deps are up to date, but somehow still getting this issue https://gist.github.com/tmcw/91093bf851f52dc540ae digging into it now... |
@anandthakker do you have an uncommitted |
Aw, crap. Yeah, that was it -- got tripped up by my own global .gitignore rule. Sorry about that! |
👍 great - I'll merge and then add a test to make sure that missing modules aren't crashers |
Add `external` option to allow whitelisting external dependencies
This adds the
external: 'globpattern'
option, which can be used to whitelist external dependencies. Glob matching is relative to thenode_modules
folders adjacent to each index, so the glob patternexternal
should matchnode_modules/external
, andexternal/node_modules/deep
should matchnode_modules/external/node_modules/deep
.