Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robust shorthand parsing. Fixes #649 #679

Merged
merged 4 commits into from Feb 24, 2017
Merged

Robust shorthand parsing. Fixes #649 #679

merged 4 commits into from Feb 24, 2017

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Feb 24, 2017

This extends findTarget and the membership interference steps, treating ObjectProperty within
var-assigned objects the same as we did for ObjectMethods. It also adds tests that specifically test
findTarget directly.

Previously in a case like

var x = {
  /** add two numbers */
  add: function(x, y) { return x + y; },
  /** subtract two numbers
  subtract(x, y) { return x + y; }
};

The subtract method wouldn't be properly nested under the x object.

Fixes #649 and fixes #678

This extends findTarget and the membership interference steps, treating ObjectProperty within

var-assigned objects the same as we did for ObjectMethods. It also adds tests that specifically test

findTarget directly."

Fixes #649 and fixes

#678
@tmcw tmcw merged commit 802dc4c into master Feb 24, 2017
@tmcw tmcw deleted the robust-shorthand-649 branch February 24, 2017 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function shorthand syntax support? Robust parsing of object method shorthand
1 participant