style(prettier): Use prettier for code formatting #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmcw
force-pushed
the
prettier
branch
2 times, most recently
from
7fdeb6a
to
fa275be
Compare
This saves us style issues. Also adds husky and lint-staged for pre-commit testing Refs #709
|
It is kind of bad that we lost eslint's feature to detect unused variables. That feature has been a life saver in many projects. |
|
Totally, I hear that. We could bring back eslint for static analysis like without using the style-guide parts. |
2 tasks
tmcw
added a commit
that referenced
this pull request
May 1, 2017
tmcw
added a commit
that referenced
this pull request
May 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches to prettier for our code style.
This saves us style issues. Also adds husky and lint-staged for pre-commit testing
Refs #709