Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix node v4 support by using babel-preset-env #874

Closed
wants to merge 6 commits into from

Conversation

tmcw
Copy link
Member

@tmcw tmcw commented Aug 11, 2017

Fixes #873

@coveralls
Copy link

Coverage Status

Coverage increased (+3.9%) to 82.439% when pulling d3f381f on transform-node-4 into ffdfa21 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.6%) to 73.981% when pulling ff7a32d on transform-node-4 into ffdfa21 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.5%) to 74.037% when pulling 699e748 on transform-node-4 into ffdfa21 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 78.532% when pulling 7b07fc0 on transform-node-4 into ffdfa21 on master.

@tmcw
Copy link
Member Author

tmcw commented Aug 11, 2017

Wow, this is terrible. I think it makes more sense to just not use new JavaScript features than to go this deep into the rabbit hole. Cross-reference: jestjs/jest#3126 (comment)

@tmcw tmcw closed this Aug 11, 2017
@tmcw tmcw deleted the transform-node-4 branch August 11, 2017 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants