Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The site backbone.js version is missing validation in save() #1906

Closed
eugen-fried opened this issue Dec 12, 2012 · 1 comment
Closed

The site backbone.js version is missing validation in save() #1906

eugen-fried opened this issue Dec 12, 2012 · 1 comment

Comments

@eugen-fried
Copy link

Hi guys,
I've been breaking my head for a while, why invalid models are persisted to server, and today looked at github version of backbone.js. What I've noticed is that in the site (http://backbonejs.org/backbone.js) version the following lines in save method:

  // Do not persist invalid models.
  if (!attrs && !this.isValid()) return false;

are missing!!!
It doesn't seem OK to me, isn't it?

@jashkenas
Copy link
Owner

Yes it is -- feel free to use master in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants