-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD and GH Actions #230
CI/CD and GH Actions #230
Conversation
This prevents backwards-incompatible devDependencies from breaking the build.
I'd prefer node 8 for checking backwards-compatibility, but our devDependencies really won't have it.
…)" This reverts the previous two commits, because I learned the hard way that actions cannot be composed out of other actions.
On other branches, CI will either trigger anyway because of the PR event, or be redundant because of the upcoming CD workflow (on prepublish and gh-pages).
Side remark: the |
Friendly reminder @joshuacc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
The purpose of the pull request is to review the design of the procedure. While the CI part is confirmed to work, I can test the CD part only after merging into
master
(I attempted testing in #235, but the workflows weren't triggered because I created them manually and they aren't onmaster
yet).Note that the
DEPLOYING.md
looks more complicated than it is. I went into details and covered all the failure scenarios I could think of, on the assumption that it is better to document a bit too much than too little. I'm open to being corrected on that count.