Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-size and fallback-size not taken into account #49

Open
obouallou opened this issue Jan 26, 2018 · 3 comments
Open

core-size and fallback-size not taken into account #49

obouallou opened this issue Jan 26, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@obouallou
Copy link

Hello,

For the standalone-server, no matter what values I put for core-size and fallback-size, I always endup with 4 runners and 8 workers. (I have 4 cores CPU)
The values are correctly set in the StandaloneWebConverterConfiguration, but I think this :

ResourceConfig resourceConfig = ResourceConfig
                .forApplication(new WebConverterApplication(configuration))
                .register(configuration);

isn't behaving as expected.

Is it a bug ?

What version of grizzly were you using ? (running 2.6 here)

@raphw
Copy link
Contributor

raphw commented Jan 27, 2018

I am using Grizzly 2.6.

I looked through the code and it seems like the pool size values are propagated correctly. What pool size did you check? Did you investigate if documents4j is sending the size values correctly?

@raphw raphw self-assigned this Jan 27, 2018
@raphw raphw added the question label Jan 27, 2018
@raphw raphw modified the milestones: 1.7.9, 1.0.3 Jan 27, 2018
@obouallou
Copy link
Author

Here's a test I did with -S 10 -B 10:
https://ibb.co/dHM0rw

You can see, that the values are correction in builder, but the httpServer doesn't take them into account.

@raphw
Copy link
Contributor

raphw commented Jan 29, 2018

Yes, the server threads are controlled by Grizzly, theses sizes adjust the converters thread pool size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants