-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing object definitions in reference section (version 2.1) #6
Comments
Thank you for the report.
Yes. Our Swagger toolchain should have renamed the object to UserSocialAccountLogins. I have filed DCM-3469
Yes, that is by design. We aren't exposing the capability to do offline signing except via the iOS SDK. |
Compiling the generated classes gives the following errors. I looked at the json and the corresponding definitions are missing [ERROR] : cannot find symbol |
Hi @roshanail , Those object definitions are reserved for DocuSign use so we don't include them in the Swagger file. |
I am also having this issue, if they are reserved for docusign there should be no reference to them in the customer facing swagger.
By design? which makes the file invalid? |
@LarryKlugerDS Is there any additional information about this? It's reasonable that you remove certain attributes from the swagger that are not used externally, however the fact that it makes the swagger invalid makes dev life a lot harder and can lead to days of head scratching. Should the swagger additionally have references to those definitions removed so that the swagger can remain valid? |
Hi, WRT to
I will ask the Engineering group to investigate. I will also raise the general issue about providing stubs. @InfinitySamurai -- what tool are you using that complains about the undefined objects? As you can see from the updated Readme, the Swagger people claim that the files are Swagger compliant. (I understand and agree with you that the objects or a stub should be included.) Note that if any of those objects are included in responses then the Swagger file won't help you decode them. |
The issue still occurs for the DocusignSignHashDocument on the newest release. Path #/definitions/signHashDocument Currently, the tooling we are using is NSwag
|
I get the same by using this tool https://github.com/ferdikoomen/openapi-typescript-codegen. PS: Using master's (March 19th) version. EDIT: PS added |
Thank you @ecdpalma , I am escalating this issue within the engineering org. |
userSocialIdResult and newAccountDefinition have a field name "socialAccountInformation" that references "#/definitions/UserSocialAccountLogins". This object does not exist.
I noticed that there is a "socialAccountInformation" object that is not referenced by any other object. Is that the correct type for the fields?
"witness" object contains the field "offlineAttributes" with a reference of "#/definitions/offlineAttributes" which does not exist.
The text was updated successfully, but these errors were encountered: