Version 6.4.2-v2.1-23.1.01.01 release (#409)

Co-authored-by: root <root@devcenteradmin.docusigntest.com>
docusign · May 10, 2023 · abeb0ae · abeb0ae
1 parent 7c30873
commit abeb0ae
Show file tree

Hide file tree

Showing 12 changed files with 32 additions and 28 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,12 @@
 # DocuSign C# Client Changelog
 
+## [v6.4.2] - eSignature API v2.1-23.1.01.01 - 2023-05-10
+### Changed
+- Removed support for .NET Framework 4.5.2. Miminum requirement is now .NET Framework 4.6.2
+- Removed [BouncyCastle.Crypto](https://www.nuget.org/packages/BouncyCastle) and [Portable.BouncyCastle](https://www.nuget.org/packages/Portable.BouncyCastle) dependencies as they've been deprecated and added [BouncyCastle.Cryptography](https://www.nuget.org/packages/BouncyCastle.Cryptography) which is the recommended replacement and is being maintained.
+- Added support for version v2.1-23.1.01.01 of the DocuSign ESignature API.
+- Updated the SDK release version.
+
 ## [v6.4.1] - eSignature API v2.1-23.1.01.01 - 2023-04-26
 ### Changed
 - Added support for version v2.1-23.1.01.01 of the DocuSign ESignature API.

diff --git a/sdk/src/DocuSign.eSign/Client/Configuration.cs b/sdk/src/DocuSign.eSign/Client/Configuration.cs
@@ -26,7 +26,7 @@ public class Configuration
         /// Version of the package.
         /// </summary>
         /// <value>Version of the package.</value>
-        public const string Version = "6.4.1";
+        public const string Version = "6.4.2";
 
         /// <summary>
         /// Identifier for ISO 8601 DateTime Format
@@ -350,7 +350,7 @@ string _trimVersionDescription(string longVersionDescription)
         /// <returns></returns>
         string _getFrameworkVersion()
         {
-#if NET452
+#if NET462
             return ".NET Framework";
 #else
             return _trimVersionDescription(System.Runtime.InteropServices.RuntimeInformation.FrameworkDescription);

diff --git a/sdk/src/DocuSign.eSign/DocuSign.eSign.csproj b/sdk/src/DocuSign.eSign/DocuSign.eSign.csproj
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8" standalone="yes"?>
 <Project Sdk="Microsoft.NET.Sdk" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <PropertyGroup Label="NuGet">
-    <TargetFrameworks>net452;netstandard2.0</TargetFrameworks>
+    <TargetFrameworks>net462;netstandard2.0</TargetFrameworks>
     <IsPackable>true</IsPackable>
     <PackageId>DocuSign.eSign.dll</PackageId>
     <Description>The DocuSign NuGet package makes integrating DocuSign into your apps and websites a super fast and painless process. The library is open sourced on GitHub, look for the docusign-esign-csharp-client repository. Join the eSign revolution!</Description>
@@ -16,7 +16,7 @@
     <RootNamespace>DocuSign.eSign</RootNamespace>
     <AssemblyName>DocuSign.eSign</AssemblyName>
     <NeutralLanguage>en-US</NeutralLanguage>
-    <VersionPrefix>6.4.1</VersionPrefix>
+    <VersionPrefix>6.4.2</VersionPrefix>
     <VersionSuffix/>
     <GenerateAssemblyInfo>true</GenerateAssemblyInfo>
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
@@ -26,22 +26,19 @@
     <PackageLicenseUrl>https://github.com/docusign/docusign-csharp-client/blob/master/LICENSE</PackageLicenseUrl>
     <RepositoryUrl>https://github.com/docusign/docusign-csharp-client</RepositoryUrl>
     <RepositoryType>git</RepositoryType>
-    <PackageReleaseNotes>[v6.4.1] - ESignature API v2.1-23.1.01.01 - 4/26/2023</PackageReleaseNotes>
+    <PackageReleaseNotes>[v6.4.2] - ESignature API v2.1-23.1.01.01 - 5/10/2023</PackageReleaseNotes>
   </PropertyGroup>
-  <PropertyGroup Condition=" '$(TargetFramework)' == 'net452'">
-    <DefineConstants>NET452</DefineConstants>
+  <PropertyGroup Condition=" '$(TargetFramework)' == 'net462'">
+    <DefineConstants>NET462</DefineConstants>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">
     <DefineConstants>NETSTANDARD2_0</DefineConstants>
   </PropertyGroup>
-  <ItemGroup Condition=" '$(TargetFramework)' == 'net452'">
-    <PackageReference Include="BouncyCastle" Version="1.8.9"/>
+  <ItemGroup Condition=" '$(TargetFramework)' == 'net462'">
     <Reference Include="System.Web"/>
   </ItemGroup>
-  <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0'">
-    <PackageReference Include="Portable.BouncyCastle" Version="1.8.10"/>
-  </ItemGroup>
   <ItemGroup>
+    <PackageReference Include="BouncyCastle.Cryptography" Version="2.2.1"/>
     <PackageReference Include="Microsoft.CSharp" Version="4.5.0"/>
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1"/>
     <PackageReference Include="System.ComponentModel.Annotations" Version="4.5.0"/>

diff --git a/sdk/src/DocuSign.eSign/Properties/AssemblyInfo.cs b/sdk/src/DocuSign.eSign/Properties/AssemblyInfo.cs
@@ -22,5 +22,5 @@
 // [assembly: AssemblyVersion("1.0.*")]
 internal class AssemblyInformation
 {
-    public const string AssemblyInformationalVersion = "6.4.1";
+    public const string AssemblyInformationalVersion = "6.4.2";
 }
diff --git a/test/SdkNetCoreTests/JwtAuthNetCoreUnitTests.cs b/test/SdkNetCoreTests/JwtAuthNetCoreUnitTests.cs
@@ -415,10 +415,10 @@ public void JwtUnexpectedPEMTypeTest()
             // Create a stream of bytes... 
             byte[] privateKeyStream = System.Text.Encoding.UTF8.GetBytes(rsaKey);
 
-            Exception ex = Assert.ThrowsException<Exception>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
+            Exception ex = Assert.ThrowsException<IOException>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
 
             Assert.IsNotNull(ex);
-            Assert.AreEqual(ex.Message, "Unexpected PEM type");
+            Assert.AreEqual(ex.Message, "no data after consuming leading dashes");
         }
 
         [TestMethod]

diff --git a/test/SdkNetCoreTests/SdkNetCoreTests.csproj b/test/SdkNetCoreTests/SdkNetCoreTests.csproj
@@ -7,6 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
+    <PackageReference Include="BouncyCastle.Cryptography" Version="2.2.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="15.7.0" />
     <PackageReference Include="MSTest.TestAdapter" Version="1.2.1" />
     <PackageReference Include="MSTest.TestFramework" Version="1.2.1" />
@@ -16,7 +17,6 @@
     <PackageReference Include="Microsoft.CSharp" Version="4.5.0" />
     <PackageReference Include="Newtonsoft.Json" Version="13.0.1" />
     <PackageReference Include="RestSharp" Version="106.12.0" />
-    <PackageReference Include="Portable.BouncyCastle" Version="1.8.10" />
     <PackageReference Include="System.ComponentModel.Annotations" Version="4.5.0" />
     <PackageReference Include="Microsoft.IdentityModel.Protocols" Version="5.4.0" />
     <PackageReference Include="System.IdentityModel.Tokens.Jwt" Version="5.4.0" />

diff --git a/test/SdkTests/JwtAuthUnitTests.cs b/test/SdkTests/JwtAuthUnitTests.cs
@@ -394,10 +394,10 @@ public void JwtUnexpectedPEMTypeTest()
             // Create a stream of bytes... 
             byte[] privateKeyStream = System.Text.Encoding.UTF8.GetBytes(rsaKey);
 
-            Exception ex = Assert.ThrowsException<Exception>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
+            Exception ex = Assert.ThrowsException<IOException>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
 
             Assert.IsNotNull(ex);
-            Assert.AreEqual(ex.Message, "Unexpected PEM type");
+            Assert.AreEqual(ex.Message, "no data after consuming leading dashes");
         }
 
         [TestMethod]

diff --git a/test/SdkTests/SdkTests.csproj b/test/SdkTests/SdkTests.csproj
@@ -43,11 +43,11 @@
     <StartupObject />
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="BouncyCastle.Crypto, Version=1.8.9.0, Culture=neutral, PublicKeyToken=0e99375e54769942">
-      <HintPath>..\packages\BouncyCastle.1.8.9\lib\BouncyCastle.Crypto.dll</HintPath>
+    <Reference Include="BouncyCastle.Cryptography, Version=2.0.0.0, Culture=neutral, PublicKeyToken=072edcf4a5328938, processorArchitecture=MSIL">
+      <HintPath>..\packages\BouncyCastle.Cryptography.2.2.1\lib\net461\BouncyCastle.Cryptography.dll</HintPath>
     </Reference>
     <Reference Include="DocuSign.eSign">
-      <HintPath>..\..\sdk\src\DocuSign.eSign\bin\Debug\net452\DocuSign.eSign.dll</HintPath>
+      <HintPath>..\..\sdk\src\DocuSign.eSign\bin\Debug\net462\DocuSign.eSign.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.CSharp" />
     <Reference Include="Microsoft.IdentityModel.JsonWebTokens, Version=5.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

diff --git a/test/SdkTests/packages.config b/test/SdkTests/packages.config
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="BouncyCastle" version="1.8.1" targetFramework="net45" />
+  <package id="BouncyCastle.Cryptography" version="2.2.1" targetFramework="net48" />
   <package id="Microsoft.IdentityModel.Logging" version="1.1.4" targetFramework="net45" />
   <package id="Microsoft.IdentityModel.Tokens" version="5.1.4" targetFramework="net45" />
   <package id="Microsoft.NETCore.Platforms" version="1.1.0" targetFramework="net48" />

diff --git a/test/SdkTests462/JwtAuthUnitTests.cs b/test/SdkTests462/JwtAuthUnitTests.cs
@@ -410,10 +410,10 @@ public void JwtUnexpectedPEMTypeTest()
             // Create a stream of bytes... 
             byte[] privateKeyStream = System.Text.Encoding.UTF8.GetBytes(rsaKey);
 
-            Exception ex = Assert.ThrowsException<Exception>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
+            Exception ex = Assert.ThrowsException<IOException>(() => _testConfig.ApiClient.RequestJWTUserToken(_testConfig.IntegratorKeyNoConsent, _testConfig.UserId, _testConfig.OAuthBasePath, privateKeyStream, _testConfig.ExpiresInHours));
 
             Assert.IsNotNull(ex);
-            Assert.AreEqual(ex.Message, "Unexpected PEM type");
+            Assert.AreEqual(ex.Message, "no data after consuming leading dashes");
         }
 
         [TestMethod]

diff --git a/test/SdkTests462/SdkTests462.csproj b/test/SdkTests462/SdkTests462.csproj
@@ -43,11 +43,11 @@
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="BouncyCastle.Crypto, Version=1.8.9.0, Culture=neutral, PublicKeyToken=0e99375e54769942">
-      <HintPath>..\packages\BouncyCastle.1.8.9\lib\BouncyCastle.Crypto.dll</HintPath>
+    <Reference Include="BouncyCastle.Cryptography, Version=2.0.0.0, Culture=neutral, PublicKeyToken=072edcf4a5328938, processorArchitecture=MSIL">
+      <HintPath>..\packages\BouncyCastle.Cryptography.2.2.1\lib\net461\BouncyCastle.Cryptography.dll</HintPath>
     </Reference>
     <Reference Include="DocuSign.eSign">
-      <HintPath>..\..\sdk\src\DocuSign.eSign\bin\Debug\net452\DocuSign.eSign.dll</HintPath>
+      <HintPath>..\..\sdk\src\DocuSign.eSign\bin\Debug\net462\DocuSign.eSign.dll</HintPath>
     </Reference>
     <Reference Include="Microsoft.CSharp" />
     <Reference Include="Microsoft.IdentityModel.JsonWebTokens, Version=5.4.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">

diff --git a/test/SdkTests462/packages.config b/test/SdkTests462/packages.config
@@ -1,6 +1,6 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="BouncyCastle" version="1.8.9" targetFramework="net462" />
+  <package id="BouncyCastle.Cryptography" version="2.2.1" targetFramework="net462" />
   <package id="Microsoft.CSharp" version="4.5.0" targetFramework="net462" />
   <package id="Microsoft.IdentityModel.JsonWebTokens" version="5.4.0" targetFramework="net462" />
   <package id="Microsoft.IdentityModel.Logging" version="5.4.0" targetFramework="net462" />