Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invokeAPI() --> ApiException() if non HTTP 200 #59

Merged
merged 3 commits into from
Mar 20, 2018
Merged

invokeAPI() --> ApiException() if non HTTP 200 #59

merged 3 commits into from
Mar 20, 2018

Commits on Feb 22, 2018

  1. invokeAPI() --> ApiException() if non HTTP 200 

    There was no error indication in case the restapi request gets back a non HTTP 200 code, e.g. HTTP 400 / 401 / 403 / ....
    @psytester
    psytester committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    0415549 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2018

  1. invokeAPI check against Family.SUCCESSFUL 

    I changed the the check against Family.SUCCESSFUL to catch all 2xx HTTP codes, the 201 Created, too.
According to DocuSign API it should be sufficient to detect successful cases.

Why I throw this exception to indicate a bad server response:
If we exit the method at line 757 or 760 with "return null;" we can not react on upper level in our application side based on HTTP code.
No indication is possible what's going wrong in that api call.

If this is not what you asked, please give me a hint ;-)
    @psytester
    psytester committed Mar 19, 2018
    Configuration menu
    Copy the full SHA
    025fcd2 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2018

  1. incorporated PR62 into this PR 

    Just in case the last change for non HTTP 2xx handling will be rejected once more and not to loose the latest changes, I added the setReadTimeout code from PR62
    @psytester
    psytester committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    56eb79d View commit details
    Browse the repository at this point in the history