Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper-case primitive from DocuSign API causes fatal error #41

Closed
wants to merge 13 commits into from

Conversation

trickeyone
Copy link

Proper-case primitive returned from DocuSign API causes fatal error

Fatal Error (1): Class 'Number' not found in [/path/to/app/vendor/docusign/esign-client/src/ObjectSerializer.php, line 274]

Also fixed the call to santitizeFilename not being called via instance or static call at line 261 by setting method to static and calling staticly.

Proper-case primitive returned from DocuSign API causes fatal error
```
Fatal Error (1): Class 'Number' not found in [/path/to/app/vendor/docusign/esign-client/src/ObjectSerializer.php, line 274]
```

Also fixed the call to `santitizeFilename` not being called via instance or static call at line 261 by setting method to static and calling staticly.
Fixed `$class` needing to be lowercase for primitive values
@benburleson
Copy link

Oh nice, this probably makes my PR unnecessary: #46

benburleson added a commit to cdins/docusign-php-client that referenced this pull request Sep 1, 2017
* PHP doesn't have a `void` type and uses `null` instead. Changed the type to be "null"
* Since "Number" isn't a valid primitive and is handled by a class, removed it from the list of primitives
Number and Date type received and aren't handled when deserializing properly causing fatal errors
```
 Fatal Error (1): Class 'Number' not found
```
@northern
Copy link

We also have these problems and they are a show stopper for us. Can these changes please be accepted, merged and released?

Thanks in advance!

@trickeyone
Copy link
Author

Could we get a response on these pull requests? There are some that have been open since 2016.

@trickeyone
Copy link
Author

Added new configuration option for #57

@Ohda Ohda mentioned this pull request Apr 24, 2018
@ccorliss
Copy link
Contributor

@trickeyone Why are there seemingly unrelated changes here - like SSL changes?

Might be a reason why this hasn't been merged yet.

@trickeyone
Copy link
Author

@ccorliss Those are in relation to #57, per my last comment. And those were recent changes, so no, that's not why it hasn't been merged.

@ccorliss
Copy link
Contributor

@gsnavin can you help merge this please? Thanks

@trickeyone
Copy link
Author

@ccorliss @gsnavin Any update on this? This is a major blocker due to errors like this:

Class 'Number' not found {"exception":"[object] (Error(code: 0): Class 'Number' not found at /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php:274)
[stacktrace]
#0 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(291): DocuSign\\eSign\\ObjectSerializer::deserialize(1, 'Number', NULL)
#1 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(236): DocuSign\\eSign\\ObjectSerializer::deserialize(Object(stdClass), '\\\\DocuSign\\\\eSign...', NULL)
#2 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(291): DocuSign\\eSign\\ObjectSerializer::deserialize(Array, '\\\\DocuSign\\\\eSign...', NULL)
#3 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(291): DocuSign\\eSign\\ObjectSerializer::deserialize(Object(stdClass), '\\\\DocuSign\\\\eSign...', NULL)
#4 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(236): DocuSign\\eSign\\ObjectSerializer::deserialize(Object(stdClass), '\\\\DocuSign\\\\eSign...', NULL)
#5 /path/to/app/app/vendor/docusign/esign-client/src/ObjectSerializer.php(291): DocuSign\\eSign\\ObjectSerializer::deserialize(Array, '\\\\DocuSign\\\\eSign...', NULL)
#6 /path/to/app/app/vendor/docusign/esign-client/src/Api/EnvelopesApi.php(7670): DocuSign\\eSign\\ObjectSerializer::deserialize(Object(stdClass), '\\\\DocuSign\\\\eSign...', Array)
#7 /path/to/app/app/vendor/docusign/esign-client/src/Api/EnvelopesApi.php(7574): DocuSign\\eSign\\Api\\EnvelopesApi->listRecipientsWithHttpInfo('1225104', '513d9084-9b0f-4...', Object(DocuSign\\eSign\\Api\\EnvelopesApi\\ListRecipientsOptions))

@trickeyone
Copy link
Author

So, it's been almost another year. Can we get an update on if this is going to be merged into 4.x or 5.x?

Joshua England and others added 2 commits March 23, 2020 18:36
@trickeyone
Copy link
Author

Closing in favor of updated #180 since this PR is well over 5 years old. Hoping the new PR with a single change will be merged to correct this issue.

@trickeyone trickeyone closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants