invokeAPI() --> ApiException() if non HTTP 200 #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no error indication in case the restapi request gets back a non HTTP 200 code, e.g. HTTP 400 / 401 / 403 / ....
mmallis87
suggested changes
Mar 18, 2018
There was a problem hiding this comment.
@psytester DocuSign API POST can return 201. I don't think it's a good idea to raise exceptions based on the HTTP response code.
I changed the the check against Family.SUCCESSFUL to catch all 2xx HTTP codes, the 201 Created, too. According to DocuSign API it should be sufficient to detect successful cases. Why I throw this exception to indicate a bad server response: If we exit the method at line 757 or 760 with "return null;" we can not react on upper level in our application side based on HTTP code. No indication is possible what's going wrong in that api call. If this is not what you asked, please give me a hint ;-)
|
@mmallis87 Why I throw this exception to indicate a bad server response: |
Just in case the last change for non HTTP 2xx handling will be rejected once more and not to loose the latest changes, I added the setReadTimeout code from PR62
mmallis87
approved these changes
Mar 20, 2018
mmallis87
added a commit
that referenced
this pull request
Aug 29, 2019
invokeAPI() --> ApiException() if non HTTP 200
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no error indication in case the restapi request gets back a non HTTP 200 code, e.g. HTTP 400 / 401 / 403 / ....