Skip to content

Commit

Permalink
chore: fix ts error in example
Browse files Browse the repository at this point in the history
  • Loading branch information
rakannimer committed Mar 10, 2020
1 parent ca6b02d commit d4ce81b
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions examples/typescript/src/components/Button.tsx
Expand Up @@ -49,9 +49,9 @@ const kinds = (outline: boolean): Kinds => {
}

export interface ButtonProps {
scale: 'small' | 'normal' | 'big'
kind: 'primary' | 'secondary' | 'cancel' | 'dark' | 'gray'
outline: boolean
scale: 'small' | 'normal' | 'big';
kind: 'primary' | 'secondary' | 'cancel' | 'dark' | 'gray';
outline: boolean;
}

const getScale = ({ scale = 'normal' }: ButtonProps) => scales[scale]
Expand Down

2 comments on commit d4ce81b

@ivoreis
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rakannimer, quick question, does it matter if you use a semicolon or not? Or why was this example wrong?

@rakannimer
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ivoreis,

It shouldn't matter I think but for some reason, tsc started choking on this and stopping the build process so I added them back for the tests to pass

Please sign in to comment.