Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Support react 17 Issue #1662 #1692

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Fix: Support react 17 Issue #1662 #1692

merged 2 commits into from
Feb 3, 2022

Conversation

prma85
Copy link
Contributor

@prma85 prma85 commented Jan 13, 2022

Description

Add React 17 to peer dependencies to not break when used within an updated project

Review

  • Check the copy
  • Build package and install with yarn link

Pre-merge checklist

  • Check for versions

Screenshots

Not needed

@prma85 prma85 mentioned this pull request Jan 13, 2022
Closed
renatobenks
renatobenks approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@renatobenks renatobenks left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for the contribution. We actually have done this in the upcoming major version, in a different way, but I guess it's totally fine we move this way sooner to get it released sooner

@renatobenks renatobenks merged commit f836dcd into doczjs:main Feb 3, 2022
@renatobenks renatobenks added the pending-release Issue fixed but not published to npm yet label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renatobenks renatobenks renatobenks approved these changes

Assignees
No one assigned
Labels
pending-release Issue fixed but not published to npm yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prma85 @renatobenks