Update to ESLint v8 #778
Merged
Update to ESLint v8 #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See standard/eslint-config-standard#208 for the tracking issue for |
|
...Fascinating because an |
|
That's a different error at least |
kylelaker-ccpo
force-pushed
the
feature/dep-updates
branch
2 times, most recently
from
a19ec08
to
01285f5
Compare
This closes out the remaining outdated packages that we continue to be notified about. Currently, we keep seeing Dependabot trying to update `eslint-plugin-promise` to v6 but that adds/requires ESLint 8 support. Unfortunately, `eslint-config-standard` v16 does not support ESLint and will not support it until v17. It seems that v17 is ready for release but they're holding off until external packages that they test compatibility with are "working" with v17. Frankly, I don't think any of the things holding those packages back are holding us back. There is a pre-release version of `eslint-config-standard` v17 that we can adopt today and start using to unblock other dependency updates. We run the lint as part of every PR, so if there's a significant issue with linting or building, we'll catch it quickly.
kylelaker-ccpo
force-pushed
the
feature/dep-updates
branch
from
01285f5
to
83649e4
Compare
|
Ahh there we go! I should have read the CHANGELOG. |
|
Since starting this PR, a production release of Standard v17 was created. |
|
Kudos, SonarCloud Quality Gate passed!
|
zachclark-ccpo
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes out the remaining outdated packages that we continue to be
notified about. Currently, we keep seeing Dependabot trying to update
eslint-plugin-promiseto v6 but that adds/requires ESLint 8 support.Unfortunately,
eslint-config-standardv16 does not support ESLint andwill not support it until v17. It seems that v17 is ready for release
but they're holding off until external packages that they test
compatibility with are "working" with v17. Frankly, I don't think any of
the things holding those packages back are holding us back. There is
a pre-release version of
eslint-config-standardv17 that we can adopttoday and start using to unblock other dependency updates.
We run the lint as part of every PR, so if there's a significant issue
with linting or building, we'll catch it quickly.