function-data-fix #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion signature. This provides better support for dynamically resolved function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When dynamically resolving APIs, was running into a situation where the resolved API was being stored in a register and the call to the resolved address invoked the register. When attempting to use
function_tracingon that call address, this resulted in aRuntimeErrorbecause when the utility attempts to useFunctionSignature, it isn't obtaining afunc_type_data_t, even when the operand type is adjusted to reflect an updated, appropriate type.Updated the code to allow the call operand type to be taken into account when a function signature is pulled.