Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ViewFactory #28

Open
dodexahedron opened this issue Dec 7, 2023 · 1 comment
Open

Add tests for ViewFactory #28

dodexahedron opened this issue Dec 7, 2023 · 1 comment
Assignees
@dodexahedron
Labels
enhancement New features or other improvements to the application or tests refactor Code conversion and refactoring work tests Items related to test projects in the solution
Milestone
Unit Test Improve...

Comments

@dodexahedron
Copy link
Owner

ViewFactory is used extensively, but it doesn't seem to have tests defined.

For any of the tests to be valid, where those tests either directly use ViewFactory, or the TGD code that they call uses ViewFactory, we need to be sure ViewFactory is valid.

This TestFixture should be defined with and Order attribute, to be sure it happens first.

All of the other tests implicitly cover ViewFactory, but nothing ever explicitly tests the validity of its output.

Not only will this improve the validity of the whole test suite, it will make it valid to remove some of the assertions in any tests that may currently make assertions against its output.
@dodexahedron dodexahedron added enhancement New features or other improvements to the application or tests refactor Code conversion and refactoring work tests Items related to test projects in the solution labels Dec 7, 2023
@dodexahedron dodexahedron added this to the Unit Test Improvements milestone Dec 7, 2023
@dodexahedron dodexahedron self-assigned this Dec 7, 2023
@dodexahedron dodexahedron mentioned this issue Dec 7, 2023
Merged
@dodexahedron
Copy link
Owner Author

On hold pending #30 and #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dodexahedron dodexahedron

Labels
enhancement New features or other improvements to the application or tests refactor Code conversion and refactoring work tests Items related to test projects in the solution
Projects
Migration to NUnit 4
Status: Hold
Milestone
Unit Test Improvements
Development

When branches are created from issues, their pull requests are automatically linked.

28-add-tests-for-viewfactory dodexahedron/TerminalGuiDesigner
1 participant
@dodexahedron