Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of rethrows keyword to reduce read/write variations #6

Merged
merged 2 commits into from Dec 26, 2023
Merged

Make use of rethrows keyword to reduce read/write variations #6

merged 2 commits into from Dec 26, 2023

Conversation

drucelweisse
Copy link
Contributor

reducing some unnecessary methods to use rethrows keyword
if closure throws it will need do catch block
otherwise it won't be needed

@AllDmeat
Copy link
Contributor

AllDmeat commented Dec 25, 2023

@drucelweisse в проверках валится степ с выгрузкой репорта в артефакты. Проверь какие права у тебя стоят в разделе «Workflow permissions» вот тут.

Должны быть такие:
Screenshot 2023-12-25 at 21 36 34

Ишью в экшне

У меня в репе всё ок. Если у тебя тоже всё ок, то пойду к своим ребятам, которые организацию держат — мб они че внезапно подкрутили в пермишнах на головном уровне.

@drucelweisse
Copy link
Contributor Author

drucelweisse commented Dec 25, 2023

@AllDmeat вроде тоже самое, может интеграция пытается прогнать на репе владельца оригинала, а не на форке? Похоже по начальным логам на это

##[debug]Primary repository: dodobrands/DBThreadSafe-ios

image

@AllDmeat
Copy link
Contributor

Видимо,но у меня тож в репе правильные настройки стоят. Спросил нашу инфру, надеюсь подскажут.

@AllDmeat AllDmeat added this pull request to the merge queue Dec 26, 2023
auto-merge was automatically disabled December 26, 2023 08:26

Merge queue setting changed

@AllDmeat AllDmeat removed this pull request from the merge queue due to the queue being cleared Dec 26, 2023
@AllDmeat AllDmeat merged commit 42dea06 into dodobrands:main Dec 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants