Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoresheet broken when no exercises in series #1663

Closed
beardhatcode opened this issue Jan 26, 2020 · 1 comment · Fixed by #1675
Closed

Scoresheet broken when no exercises in series #1663

beardhatcode opened this issue Jan 26, 2020 · 1 comment · Fixed by #1675
Labels
bug Something isn't working
Milestone
3.3

Comments

@beardhatcode
Copy link
Member

Screen Shot 2020-01-26 at 14 23 33

This is due to the absolute positioning of the username col and the fact that there are no other cols to make the table grow.

Example:
https://dodona.ugent.be/nl/series/1364/scoresheet/

Tested in FF74
@beardhatcode
Copy link
Member Author

My suggested solution is to just not show the table and show an info message instead.

There are no exercises in this series. You can add some in the serries edit page.

@chvp chvp added the bug Something isn't working label Jan 26, 2020
@chvp chvp added this to the 3.3 milestone Jan 26, 2020
@chvp chvp mentioned this issue Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

Show a message on the scoresheet when a series doesn't contain any exercises dodona-edu/dodona
2 participants
@beardhatcode @chvp