Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redirect_to_default_host should not throw away query parameters #1553

Merged
merged 1 commit into from Dec 8, 2019
Merged

redirect_to_default_host should not throw away query parameters #1553

merged 1 commit into from Dec 8, 2019

Conversation

rien
Copy link
Member

@rien rien commented Dec 3, 2019

This fixes a bug where a media object was inaccessible because when redirecting to the default_host, the token was thrown away.

  • Tests were added

@rien rien requested review from bmesuere and chvp December 3, 2019 15:00
@chvp chvp added the bug fix label Dec 6, 2019
@chvp chvp added this to the 3.3 milestone Dec 6, 2019
@rien rien merged commit 0b2252b into develop Dec 8, 2019
@rien rien deleted the fix/exercise-media-redirect-without-token branch December 8, 2019 14:43
@rien rien mentioned this pull request Dec 16, 2019
Closed
@bmesuere bmesuere added the bug Something isn't working label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmesuere bmesuere bmesuere approved these changes

@chvp chvp chvp approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rien @bmesuere @chvp