Allow normal users to search submissions #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rien
reviewed
Jan 30, 2020
| @@ -125,7 +125,7 @@ def set_submissions | |||
| end | |||
| if params[:course_id] | |||
| @course = Course.find(params[:course_id]) | |||
| @course_labels = CourseLabel.where(course: @course) if @user.blank? | |||
| @course_labels = CourseLabel.where(course: @course) if @user.blank? && current_user.course_admin?(@course) | |||
There was a problem hiding this comment.
This will crash if current_user is nil (but I doubt if that will ever be the case).
There was a problem hiding this comment.
I realized this while writing the code, but a logged out user can never see submissions.
There was a problem hiding this comment.
I guess this callback is executed before permission checking though, so a logged out user constructing the right URL could technically trigger a crash. I'll change it.
The only way to test this new behaviour is through system testing, the user could already do so via the API. |
|
Hmm, we don't have any tests related to searching yet AFAICT, so I'll add some. |
chvp
force-pushed
the
fix/allow-normal-users-to-search-submissions
branch
from
e61bd08
to
e14e7dc
Compare
bmesuere
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1660.