Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit memory usage of statistics calculations #1687

Merged
merged 1 commit into from Feb 7, 2020

Conversation

chvp
Copy link
Member

@chvp chvp commented Feb 6, 2020

Instead of loading all (new) submissions, the in_batches method is used to process 1000 new submissions at a time.

@chvp chvp added the bug fix label Feb 6, 2020
@chvp chvp added this to the 3.3 milestone Feb 6, 2020
@chvp chvp requested review from bmesuere and rien February 6, 2020 07:23
@chvp
Copy link
Member Author

chvp commented Feb 6, 2020

I was going to test this on Naos, but https://github.com/dodona-edu/dodona-ansible/issues/52 prevented me from doing so.

@chvp
Copy link
Member Author

chvp commented Feb 6, 2020

Works on naos.

Instead of loading all (new) submissions, the `in_batches` method is used to process 1000 new submissions at a time.
@chvp chvp force-pushed the fix/limit-memory-usage-of-statistics-calculations branch from 5b09ce6 to f77449c Compare February 6, 2020 10:38
@chvp chvp merged commit 3ee7299 into develop Feb 7, 2020
@chvp chvp deleted the fix/limit-memory-usage-of-statistics-calculations branch February 7, 2020 08:49
@bmesuere bmesuere added the bug Something isn't working label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants