Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time and memory limit status to partial format #1790

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

niknetniko
Copy link
Member

This pull request adds the status memory limit exceeded and time limit exceeded to the partial output format.

@ninewise
Copy link

ninewise commented Mar 30, 2020 via email

@pdawyndt
Copy link
Contributor

@ninewise Is there any reporting on finished (closed) test cases/contexts/tabs in case Dodona traps a timeout or memory overflow?

@ninewise
Copy link

ninewise commented Mar 30, 2020 via email

@chvp
Copy link
Member

chvp commented Mar 31, 2020

I'm in favor of merging this. This doesn't increase the complexity of the result constructor at all (its code isn't even touched), and allows judges using the partial output format to do more.

@bmesuere
Copy link
Member

@ninewise what's your final say on this?

@ninewise
Copy link

ninewise commented Mar 31, 2020 via email

@bmesuere bmesuere merged commit f848ebf into dodona-edu:develop Mar 31, 2020
@chvp
Copy link
Member

chvp commented Mar 31, 2020

One reason for memory at least is that depending on how the language handles out of memory errors the judge might crash and result in an internal error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants