-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take all javascript into account for coverage calculation #4526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently:
|
jorg-vr
changed the title
Add javascript coverage for system tests
Take into account all javascript for coverage
Mar 29, 2023
jorg-vr
requested review from
bmesuere and
niknetniko
and removed request for
a team
March 29, 2023 08:15
niknetniko
approved these changes
Mar 29, 2023
bmesuere
changed the title
Take into account all javascript for coverage
Take all javascript into account for coverage calculation
Mar 29, 2023
bmesuere
approved these changes
Mar 29, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adjust the code coverage calculations to get a better view of our code coverage.
It fixes the coverage of javascript tests by including all javascript files. (Not just those touched by at least one test)
It fixes the javascript coverage of the system tests (which was not calculated before).
I have also updated the codecov setting to lower the default allowed deviation for the project to 0.25 (Used to be 1).