Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take all javascript into account for coverage calculation #4526

Merged
merged 10 commits into from
Mar 29, 2023

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Mar 28, 2023

This pull request adjust the code coverage calculations to get a better view of our code coverage.

It fixes the coverage of javascript tests by including all javascript files. (Not just those touched by at least one test)
It fixes the javascript coverage of the system tests (which was not calculated before).

I have also updated the codecov setting to lower the default allowed deviation for the project to 0.25 (Used to be 1).

@jorg-vr jorg-vr added the chore Repository/build/dependency maintenance label Mar 28, 2023
@jorg-vr jorg-vr self-assigned this Mar 28, 2023
@jorg-vr
Copy link
Contributor Author

jorg-vr commented Mar 29, 2023

Currently:

  • system coverage goes down => expected, more files considered
  • project coverage goes down => unexpected, all javascript files should have already been considered by javascript tests
  • project coverage is accepted with large decrease => Unexpected, I only allowed 0.25% decrease in Allow some deviation from the code coverage #4524
    image

@jorg-vr jorg-vr changed the title Add javascript coverage for system tests Take into account all javascript for coverage Mar 29, 2023
@jorg-vr jorg-vr marked this pull request as ready for review March 29, 2023 08:15
@jorg-vr jorg-vr requested a review from a team as a code owner March 29, 2023 08:15
@jorg-vr jorg-vr requested review from bmesuere and niknetniko and removed request for a team March 29, 2023 08:15
@bmesuere bmesuere changed the title Take into account all javascript for coverage Take all javascript into account for coverage calculation Mar 29, 2023
@jorg-vr jorg-vr merged commit 49bbd3b into develop Mar 29, 2023
@jorg-vr jorg-vr deleted the chore/system-js-coverage branch March 29, 2023 13:46
@jorg-vr jorg-vr mentioned this pull request Mar 30, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Repository/build/dependency maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants