Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries should use semantic versioning #1280

Closed
rien opened this issue Oct 23, 2023 · 3 comments
Closed

Libraries should use semantic versioning #1280

rien opened this issue Oct 23, 2023 · 3 comments

Comments

@rien
Copy link
Member

rien commented Oct 23, 2023

We're noticing more developers are using our library (dolos-lib) and with the new core library coming up (dolos-core) we should adhere to semantic versioning.

Up till now we've used the same version for all our packages, and we've only bumped our major version when Dolos had a drastic UI change. However, we've often made breaking changes to our library which should've been a major version bump. This makes it hard for dependents to integrate our libraries.

I propose we keep our current versioning scheme for our apps (CLI and Web UI), but switch to semantic versioning for the libraries. To signify this change, we can bump dolos-lib and dolos-core in our next release to 3.0.0.

Future releases will always release a new version of our apps (CLI, Web UI or webserver), but the libraries might not change.

@TRISHAHALDER

This comment was marked as off-topic.

@rien

This comment was marked as off-topic.

@rien
Copy link
Member Author

rien commented Sep 19, 2024

We have been implementing this lately, so this issue can be closed.

@rien rien closed this as completed Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants