Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix share URL not including base url path #1131

Merged
merged 1 commit into from May 26, 2023
Merged

Fix share URL not including base url path #1131

merged 1 commit into from May 26, 2023

Conversation

rien
Copy link
Member

@rien rien commented May 26, 2023

The share URL was only using the window.location's origin which does not include the path. Using the full href should fix this issue.

Closes #1129,

@rien rien merged commit d8490a1 into main May 26, 2023
19 checks passed
@rien rien deleted the fix/share-url branch May 26, 2023 13:22
@rien rien added the bug Something isn't working label Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share this report link doesn't work
1 participant